D28115: feat(kded): add a dbus method to lock current rotation

romangg added a comment. In D28115#632489 , @davidedmundson wrote: > How does mobile retrieve the current lockAutoRotate value? It could read it from the config file. But it would be better to add another dbus method for that.

D28115: feat(kded): add a dbus method to lock current rotation

davidedmundson added a comment. How does mobile retrieve the current lockAutoRotate value? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28115: feat(kded): add a dbus method to lock current rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7e98fd7c1b29: feat(kded): add a dbus method to lock current rotation (authored by bshah). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=78233=78234

D28115: feat(kded): add a dbus method to lock current rotation

bshah updated this revision to Diff 78233. bshah added a comment. whitespace REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=78232=78233 BRANCH arcpatch-D28115 REVISION DETAIL https://phabricator.kde.org/D28115 AFFECTED FILES

D28115: feat(kded): add a dbus method to lock current rotation

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > config.cpp:103 > +} > +if(m_control->getAutoRotate(output) != value) { > +m_control->setAutoRotate(output, value); On push change to: `if

D28115: feat(kded): add a dbus method to lock current rotation

bshah updated this revision to Diff 78232. bshah added a comment. - rename methods to AutoRotate - write control file after change, thanks @romangg for suggestion REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=77896=78232 BRANCH

D28115: feat(kded): add a dbus method to lock current rotation

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Please call the functions `AutoRotate`. I failed to name it consistently in the code until now but let's go with AutoRotate from now on (and I will try to rename it where I

D28115: feat(kded): add a dbus method to lock current rotation

bshah added a comment. This works as expected API wise and functionality wise, but internally control config is not written at all. :/ REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,