D28129: Read the new message string after rather than before

This revision was automatically updated to reflect the committed changes. Closed by commit R871:cfa43ed278c8: Read the new message string after rather than before (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78627=78628

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78627. apol added a comment. address weird +2 in the code REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78605=78627 BRANCH arcpatch-D28129 REVISION DETAIL https://phabricator.kde.org/D28129 AFFECTED FILES

D28129: Read the new message string after rather than before

sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + >

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78605. apol added a comment. Don't leak REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78604=78605 BRANCH arcpatch-D28129 REVISION DETAIL https://phabricator.kde.org/D28129 AFFECTED FILES

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78604. apol marked 3 inline comments as done. apol added a comment. Rebase on top of ksyntaxhighlighting, works great REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78117=78604 BRANCH arcpatch-D28129 REVISION

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78117. apol added a comment. This revision is now accepted and ready to land. Fix it in a theoretically better but more convoluted way REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=77929=78117 BRANCH master

D28129: Read the new message string after rather than before

sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D28129: Read the new message string after rather than before

apol planned changes to this revision. apol added a comment. Just tested it properly, it fails to generate a backtrace altogether :( REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D28129: Read the new message string after rather than before

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D28129: Read the new message string after rather than before

apol created this revision. apol added reviewers: Frameworks, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way if we're linking against an old KF5, we still generate a backtrace