D28180: [applets/systemtray] Hide/show expander arrow - regression fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b34e88da7a5d: [applets/systemtray] Hide/show expander arrow - regression fix (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka updated this revision to Diff 82205. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28180?vs=78148=82205 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28180 AFFECTED FILES

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. Ah, right, we just use the sort filter model, no model from C++. Meh, so I can't think of a better way right now either.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. I would suggest we add a `count` property with a `NOTIFY` signal on the model which is then updated on C++ side? I find that cleaner than doing that from QML like this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To:

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. #plasma ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added a comment. In D28180#632058 , @ngraham wrote: > This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to comment. Oh and thanks for the code comments. Always very helpful! REPOSITORY R120

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.itemCount > 0 > ideally `root.hiddenLayout.count` should be used, but `count` is not

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Expander arrow should hide when all