D28185: [applet/systemtray] Us model binding instead of copy

2020-03-21 Thread Konrad Materka
kmaterka added a comment. In D28185#631972 , @apol wrote: > I'm not convinced this is all that better. Without this `effectiveStatus` never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a

D28185: [applet/systemtray] Us model binding instead of copy

2020-03-21 Thread Konrad Materka
kmaterka updated this revision to Diff 78178. kmaterka added a comment. Bind model as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78169=78178 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES

D28185: [applet/systemtray] Us model binding instead of copy

2020-03-21 Thread Aleix Pol Gonzalez
apol added a comment. I'm not convinced this is all that better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28185 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28185: [applet/systemtray] Us model binding instead of copy

2020-03-21 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY The `effectiveStatus` parameter was passed as a copy, use proper binding. TEST