D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-27 Thread Nathaniel Graham
ngraham added a comment. In D28200#636071 , @develoot wrote: > In D28200#633124 , @ngraham wrote: > > > Anyway, @develoot, could you provide your email address so we can land this patch with proper

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-27 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use KMessageWidget (authored by develoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-27 Thread Kitae Kim
develoot added a comment. In D28200#633124 , @ngraham wrote: > Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? My email address is devel...@gmail.com. thanks.

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-23 Thread Nathaniel Graham
ngraham added a comment. Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28200 To: develoot, #vdg, #plasma, #frameworks, davidedmundson Cc:

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-22 Thread Nathaniel Graham
ngraham added a comment. In D28200#632622 , @davidedmundson wrote: > > I wonder if it makes sense to set this on the widget itself, as a sensible default. > > No. > > Not because it's a better or worse default, but because making a

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I wonder if it makes sense to set this on the widget itself, as a sensible default. No. Not because it's a better or worse default, but because making a

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-22 Thread Nathaniel Graham
ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. Thanks for the patch! I wonder if it makes sense to set this on the widget itself, as a sensible default. You're probably going to want to word-wrap more often than you aren't. REPOSITORY R119 Plasma Desktop REVISION

D28200: Enable wrapping of error messages which use KMessageWidget

2020-03-22 Thread Kitae Kim
develoot created this revision. develoot added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. develoot requested review of this revision. REVISION SUMMARY Error messages should be shown to users no matter how much long it is. REPOSITORY R119 Plasma