D28211: [applets/systemtray] Make Pin button a bit larger

ngraham updated this revision to Diff 78300. ngraham added a comment. Remove all size overrides; the problem is in the Plasma theme icon having no padding and will be fixed there in a different patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. icon comes from plasma theme, which is F8195182: image.png it needs padding REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb, mart Cc: mart, ndavis,

D28211: [applets/systemtray] Make Pin button a bit larger

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. wait, if you mean that you want the pin button with 22x22px icon size, this patch is not correct and it should have no size parameters REPOSITORY R120 Plasma Workspace REVISION

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. if the size of that button changes in systray, it muct change in calndar too REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb Cc: mart,

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a subscriber: mart. ngraham added a comment. The PC3 ToolButton has been "fixed" half a dozen times already and I imagine poor @mart is thoroughly sick of it by now... REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28211: [applets/systemtray] Make Pin button a bit larger

ndavis added a comment. In D28211#632893 , @ngraham wrote: > The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png > > However yeah, the actual icon size in a

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a comment. The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png However yeah, the actual icon size in a ToolButton is `smallMedium`, so I guess the fact that you need to use `small` to get the

D28211: [applets/systemtray] Make Pin button a bit larger

broulik added a comment. F8194458: Screenshot_20200323_102203.png Gets pretty large here, surely bigger than `small` icon size. Maybe another PlasmaComponents 3 issue? REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched

D28211: [applets/systemtray] Make Pin button a bit larger

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 for using standard size instead of using an hardcoded size. REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Pin button in the System Tray expanded view is very small. This has always felt