D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in background.cpp:165 > From the docs > > Commandline to use add when autostarting at login. >If this is not specified, the Exec line from the >desktop file will be used. > > I can't see us doing that last

D28214: Add background portal

jgrulich added a comment. In D28214#643478 , @bcooksley wrote: > This change, as committed does not appear to compile: >

D28214: Add background portal

davidedmundson added inline comments. INLINE COMMENTS > background.cpp:165 > +qCDebug(XdgDesktopPortalKdeBackground) << "enable: " << enable; > +qCDebug(XdgDesktopPortalKdeBackground) << "commandline: " << > commandline; > +qCDebug(XdgDesktopPortalKdeBackground) << "

D28214: Add background portal

bcooksley added a comment. This change, as committed does not appear to compile: https://build.kde.org/view/Failing/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/lastFailedBuild/console REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL

D28214: Add background portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:0cefb5e18db4: Add background portal (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28214?vs=79515=79551#toc REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D28214: Add background portal

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jgrulich wrote in background.cpp:194 > Doesn't need to? I think it just specifies that the desktop file should > ignore the exec line and start it through DBus (assuming

D28214: Add background portal

jgrulich updated this revision to Diff 79515. jgrulich marked 5 inline comments as done. jgrulich added a comment. Update to fix review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78272=79515 BRANCH

D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > apol wrote in background.cpp:69 > I don't really understand why we're exposing this. Is it for contained apps? This is actually not API exposed to the clients, this is purely for xdg-desktop-portal needs, while the client interface

D28214: Add background portal

apol added inline comments. INLINE COMMENTS > background.cpp:69 > +qCDebug(XdgDesktopPortalKdeBackground) << "GetAppState called: no > parameters"; > +return m_appStates; > +} I don't really understand why we're exposing this. Is it for contained apps? > background.cpp:133 > + > +

D28214: Add background portal

jgrulich updated this revision to Diff 78272. jgrulich added a comment. Avoid potential crash when captured variable goes out of scope REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78271=78272 BRANCH

D28214: Add background portal

jgrulich updated this revision to Diff 78271. jgrulich added a comment. Replace my custom function for quoting of arguments with KShell REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78270=78271 BRANCH

D28214: Add background portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Implements Background portal, providing APIS related to applications running in the background. Implemented according to: