This revision was automatically updated to reflect the committed changes.
Closed by commit R111:7a13a67827ea: Fix Formatter library CMake (authored by
ahiemstra).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28217?vs=78276&id=78282
REVISION DETAIL
ahiemstra added inline comments.
INLINE COMMENTS
> romangg wrote in CMakeLists.txt:30
> I removed experimentally the Qml and Quick package specifiers and it still
> compiled.
It's in response to the comment here: https://phabricator.kde.org/D27869#632172
REPOSITORY
R111 KSysguard Library
BR
romangg added inline comments.
INLINE COMMENTS
> romangg wrote in CMakeLists.txt:30
> Accidentally added QML and Quick?
I removed experimentally the Qml and Quick package specifiers and it still
compiled.
REPOSITORY
R111 KSysguard Library
BRANCH
cmake_fixes
REVISION DETAIL
https://phab
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Compiles again on Neon.
INLINE COMMENTS
> CMakeLists.txt:30
>
> -find_package(Qt5 ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS DBus Network
> Widgets)
> +find_package(Qt5 ${QT_MIN_VERS
ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
On older versions, install(TARGETS target PUBLIC_HEADER) does not seem
to work too well, s
