D28262: [applets/analog-clock] Optional minute hand

ngraham added a comment. Heh. Thanks anyway! And now you have a dev environment set up so your next patch will be easier. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma, ngraham Cc: broulik, ngraham, aloiseau,

D28262: [applets/analog-clock] Optional minute hand

aloiseau abandoned this revision. aloiseau added a comment. No problem :) If someone find it useful, then he/she will find it there and can apply it locally in its ~/.local/share folder. Note for anyone wanting to apply this patch locally in the future: hiding minute marks around the clock

D28262: [applets/analog-clock] Optional minute hand

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not sure I think this makes sense, sorry. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma, ngraham

D28262: [applets/analog-clock] Optional minute hand

aloiseau added a comment. In D28262#634715 , @broulik wrote: > > I can not find a kcfg file in this applet to simply extend > > In applets it's the `config.xml` you edited, so from a technical POV patch is good. Not sure this option is very

D28262: [applets/analog-clock] Optional minute hand

broulik added a comment. > I can not find a kcfg file in this applet to simply extend In applets it's the `config.xml` you edited, so from a technical POV patch is good. Not sure this option is very useful, however. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28262: [applets/analog-clock] Optional minute hand

aloiseau added a comment. Thanks Nathaniel for your feedbacks. About your technical comment, I can not find a kcfg file in this applet to simply extend. I will have a closer look to existing kcfg files and create one for analog clock (next weekend I guess) About the conceptual

D28262: [applets/analog-clock] Optional minute hand

kossebau resigned from this revision. kossebau added a comment. Resigning, due to currently not having time for Plasma development. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma Cc: ngraham, aloiseau, plasma-devel, Orage,

D28262: [applets/analog-clock] Optional minute hand

ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces. ngraham added a comment. Thanks for the patch, Anthony! Technical comment: you need to update the kcfg file too, to add a definition of the new option. Conceptual/UI comment: do you think you could explain

D28262: [applets/analog-clock] Optional minute hand

aloiseau created this revision. aloiseau added reviewers: Plasma: Workspaces, kossebau. aloiseau added a project: Plasma: Workspaces. Herald edited projects, added Plasma; removed Plasma: Workspaces. Herald added a subscriber: plasma-devel. aloiseau requested review of this revision. REVISION