D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a5e0bc0880b: [kcms/baloo] Refine UI and prepare for more indexing options in the future (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D28280#640239 , @ngraham wrote: > Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch is to future-proof the UI for the addition of more options, which is coming soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis added a comment. Why isn't a checkbox better than a combobox here? Aren't there only 2 opposite choices here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Right, so my intention was to make it easy to add a new entry to the combobox titled "Metadata-only indexing". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634471 , @ngraham wrote: > Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail.

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail. However we probably don't have to worry too much about that for the purpose of

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634405 , @ngraham wrote: > In D28280#634388 , @bruns wrote: > > > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options.

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. In D28280#634388 , @bruns wrote: > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. That would be fine. Comboboxes handle many options pretty well. In

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. For the "Add folder setting...": How about a config dialog **after** the File Dialog? This may seem over the top for now, but the next step is to make the excludeFilters and mimetype filters configurabe from the KCM, and then also per folder. REPOSITORY R119

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage, LeGast00n,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham updated this revision to Diff 78455. ngraham added a comment. use `onActivated:` rather than `onCurrentIndexChanged:` for the combobox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28280?vs=78454=78455 BRANCH refine-baloo-kcm-ui

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham created this revision. ngraham added reviewers: VDG, Baloo, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch refines the UI added in D28025 . The