epopov added inline comments.
INLINE COMMENTS
> broulik wrote in CalendarView.qml:154
> Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs
> since epoch)
How can I compare only the date using your expression?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> CalendarView.qml:154
>
> +function dateEquals(date1, date2) {
> +var values1 = [
Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs
since epoch)
REPOSITORY
R120 Plasma Workspace
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a05dc73cf7fb: [applets/digital-clock] Fix calendar events
not being shown at first (authored by epopov, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
epopov updated this revision to Diff 78853.
epopov added a comment.
Rebase to `master`
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28354?vs=78715=78853
REVISION DETAIL
https://phabricator.kde.org/D28354
AFFECTED FILES
ngraham added a comment.
Can you rebase this patch on current master?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28354
To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas,
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28354
To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n,
epopov updated this revision to Diff 78715.
epopov added a comment.
Put the `dateEquals` function outside the `onAgendaUpdated` handler, so it
can be used elsewhere.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28354?vs=78694=78715
REVISION
ngraham added a comment.
If you're gonna have the function live inside the `onAgendaUpdated:` handler
and only be used once, it might as well not be a function at all. :) If you
want to keep it a function, it would be good to put it higher up in the file,
so it can potentially be used by
epopov updated this revision to Diff 78694.
epopov added a comment.
Make a function that compares dates inline.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28354?vs=78670=78694
REVISION DETAIL
https://phabricator.kde.org/D28354
AFFECTED
