D28619: BookmarksRunner: Remove caching of profile database path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:768e6a0a229d: BookmarksRunner: Remove caching of profile database path (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80580&id

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80580. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80578&id=80580 REVISION DETAIL https://phabricator.kde.org/D28619 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGa

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80578. alex added a comment. Implement requested changes Thanks, I will do that after the bugfix is done :-) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=79466&id=80578 BRANCH arcpatch-D28619 R

D28619: BookmarksRunner: Remove caching of profile database path

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please just remove the `writeEntry`. You can then propose "But what about renaming the dbfile entry, maybe to alternate_dbfile?" as another review. REPOSITORY R120 Plasma Wor

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. Friendly ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28619 To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. > I would argue for just removing the `grp.writeEntry("dbfile", m_dbFile)` line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config ha

D28619: BookmarksRunner: Remove caching of profile database path

bruns added a comment. There are two possible ways of changing the caching, and each one will break behavior for one of two different groups of users: 1. People who rely on the krunner following the default profile. 2. People who rely on krunner using the dbfile config entry. I wou

D28619: BookmarksRunner: Remove caching of profile database path

alex created this revision. alex added reviewers: Plasma, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch removes the caching