D28678: adjust smb kcm size to be sufficient vis a vis headers

ngraham added a comment. In D28678#648072 , @mart wrote: > I think I'll take a look into that (i mean, replacing kcmshell with systemsettings) <3 <3 <3 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D28678

D28678: adjust smb kcm size to be sufficient vis a vis headers

mart added a comment. In D28678#644926 , @ngraham wrote: > I really wish that KCMshell didn't add its own scrollview, so we didn't end up with issues like this. The KCM itself should be responsible for its own layouting needs. > > Then

D28678: adjust smb kcm size to be sufficient vis a vis headers

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f2c5e10d4af3: adjust smb kcm size to be sufficient vis a vis headers (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28678?vs=79638=80087

D28678: adjust smb kcm size to be sufficient vis a vis headers

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I really wish that KCMshell didn't add its own scrollview, so we didn't end up with issues like this. The KCM itself should be responsible for its own layouting needs. Then again I

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter added a comment. F8225234: Screenshot_20200408_142242.png F8225237: Screenshot_20200408_142227-1.png F8225239: Screenshot_20200408_142309.png REPOSITORY

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we use Stretch to get a somewhat uniform appearance between the two views but Stretch is bit meh