D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol added a comment. This is on https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/1 now. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28884 To: apol, jgrulich Cc: davidedmundson, jgrulich, plasma-devel,

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R838:0d2bd657963c: screencasting: Adoption of the org_kde_plasma_video_streaming protocol (authored by apol). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 82302. apol added a comment. Adapt to changes in the protocol, implement windows REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81926=82302 BRANCH arcpatch-D28884 REVISION

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81926. apol added a comment. Rebase on top of kwayland-server changes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81343=81926 BRANCH arcpatch-D28884 REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81343. apol added a comment. Explicitly request zkde_screencast_unstable_v1 REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81115=81343 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81115. apol added a comment. Adapt to the changes in hte kwayland patch REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80985=81115 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good and it works for me, tested with Chromium. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

davidedmundson added a comment. Generally +1 INLINE COMMENTS > waylandintegration.cpp:452 > +connect(m_registry, ::Client::Registry::screencastingAnnounced, > this, [this] (quint32 name, quint32 version) { > +qDebug() << "screen!"; > +m_screencasting =

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80985. apol added a comment. Adopt kwayland changes, provide the right buffer size. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80797=80985 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80797. apol added a comment. Remember to run the event loop REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80795=80797 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80795. apol added a comment. Remove conditional compilation to pipewire It's not in this module, we don't need to depend on it. Also removes code regarding EGL initialization that I think now is not necessary. REPOSITORY R838 Flatpak Support: KDE

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration.cpp:310 > > -// HACK wait for stream to be ready > -QTimer::singleShot(3000, , ::quit); This has been removed, but I think it will still be needed. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added a comment. With all code relevant to PipeWire removed, you can remove all needed CMake find modules in cmake subdir and you can also remove the ENABLE_PIPEWIRE option as it shouldn't be needed anymore (including all ifdefs). REPOSITORY R838 Flatpak Support: KDE Portal for

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80719. apol added a comment. Proper initialisation REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80663=80719 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80663. apol added a comment. Adadpt to changes in kwayland D28882 REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80408=80663 BRANCH

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80408. apol added a comment. Renamed classes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80340=80408 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28884

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration_p.h:126 > KWayland::Client::FakeInput *m_fakeInput = nullptr; > -KWayland::Client::RemoteAccessManager *m_remoteAccessManager = nullptr; > +KWayland::Client::VideoStreaming *m_remoteAccessManager = nullptr; >

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80340. apol added a comment. Include the notification REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80285=80340 BRANCH master REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80285. apol added a comment. Fix build REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80280=80285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28884

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of creating the pipewire feeds in the portal, they will be created in KWin. Then the portal task becomes to orchestrate the