broulik planned changes to this revision.
broulik added a comment.
I've noticed I accidentally removed compiling a few things, that also depend
on KIO, so maybe not as lean as I hoped
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D28904
To: broulik, #plasma
Cc:
broulik added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:20
> That's not right at least. It should be optional when KF5NetworkManagerQt is
> found. It looks weird to present at all.
Yes, this looks wrong but I don't understand why I even have to add this
manually
anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:20
>
> -find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus
> X11Extras)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth
> IdleTime Config DBusAddons Solid I18n GlobalAccel
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
That unused `EditPage::openUrl` pulled in `KIOWidgets` with all its
dependencies.
This includes
broulik updated this revision to Diff 80351.
broulik edited the test plan for this revision.
broulik added a comment.
- Drop all `KComboBox` uses
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28904?vs=80350&id=80351
REVISION DETAIL
https://phabricato
