D29057: Introduce PlaceholderMessage component

ngraham added a comment. Oops. Fixed in 4c6252526c122081f7ac699d2655dc80306fde78 . Sorry about that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami,

D29057: Introduce PlaceholderMessage component

nicolasfella added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:26 > + * @code{.qml} > + * import org.kde.kirigami 2.11 as Kirigami > + ** used as a "this view is empty" message This needs to be 2.12 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057

D29057: Introduce PlaceholderMessage component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5a434519aeb9: Introduce PlaceholderMessage component (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80892=80929 REVISION DETAIL

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80892. ngraham added a comment. Add another code example showing now you could use it as a loading indicator REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80825=80892 BRANCH placeholder-message (branched

D29057: Introduce PlaceholderMessage component

leinir added a comment. Nice! Got a few places where this could be very handy :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80825. ngraham added a comment. Add margins to examples REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80782=80825 BRANCH placeholder-message (branched from master) REVISION DETAIL

D29057: Introduce PlaceholderMessage component

abetts added a comment. Look cool! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80782. ngraham marked 13 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80777=80782 BRANCH placeholder-message (branched from

D29057: Introduce PlaceholderMessage component

broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:118 > + */ > +property QQC2.Action helperAction > + You can probably just make an `alias` to the button's `action` property. It got added in Qt 5.10, then it should take on the icon, text, visibility, trigger, etc

D29057: Introduce PlaceholderMessage component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PlaceholderMessage.qml:10 > +import QtQuick.Layouts 1.13 > +import org.kde.kirigami 2.12 > + as convention (sadly not used everywhere in the sources but at least

D29057: Introduce PlaceholderMessage component

cblack added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:20 > + * > + * @code > + * import org.kde.kirigami 2.11 as Kirigami `@code{.qml}` > PlaceholderMessage.qml:40 > + * > + ** Used as a "here's how to proceed" message > + * ListView { Split into own codeblock >

D29057: Introduce PlaceholderMessage component

ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch creates the `PlaceholderMessage`, a re-usable component that can be