D29071: FileChooser portal: add support for opening directories

2020-04-28 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R838:976d0c5fade9: FileChooser portal: add support for opening directories (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D29071: FileChooser portal: add support for opening directories

2020-04-28 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-directory REVISION DETAIL https://phabricator.kde.org/D29071 To: jgrulich, apol,

D29071: FileChooser portal: add support for opening directories

2020-04-21 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > filechooser.cpp:167 > > +if (options.contains(QStringLiteral("directory"))) { > +directory = options.value(QStringLiteral("directory")).toBool(); This check isn't needed, but is probably consistent with the rest and should be

D29071: FileChooser portal: add support for opening directories

2020-04-21 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-directory REVISION DETAIL https://phabricator.kde.org/D29071