This revision was automatically updated to reflect the committed changes.
Closed by commit R845:fbd32235c6ac: [applet] Port to
Kirigami.PlaceholderMessage (authored by ngraham).
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29110?vs=80938&id=81059
REVIS
ngraham added a comment.
Thanks!
REPOSITORY
R845 Plasma Vault
BRANCH
port-to-PlaceholderMessage (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29110
To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.
Fair enough.
REPOSITORY
R845 Plasma Vault
BRANCH
port-to-PlaceholderMessage (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29110
To: ngraham, #vdg, #plasma, ivan, n
ngraham added a comment.
I know what you mean, but Kirigami is already a dependency of Plasma itself,
which a user of Plasma Vaults presumably already has installed. :)
When I created the ExpandableListItem, I put it in plasma-framework, but I
almost put it in Kirigami, and for Plasma 6,
ivan added a comment.
Not sure I like pulling in Kirigami just for this. Are there other places
where Kirigami could improve the Vaults applet?
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D29110
To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, O
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, ivan, niccolove.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch ports the Vaults applet to use the new
`Kirigami.PlaceholderMessa
