This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a960c028c71d: Bookmarks Runner: Fix extraction of firefox
profile (authored by alex).
REPOSITORY
R120 Plasma
alex added a comment.
Ping
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29326
To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, ragreen, ZrenBot,
alex added a comment.
Friendly Ping @bruns or may I land this already ?
And should this land on `Plasma/5.19`?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29326
To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage,
alex added a comment.
@bruns LGTM?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29326
To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, ragreen,
meven added a comment.
We should not have screenshots in git commit message as they are not durable.
(Only in test plan section is tolerable)
I think you can change your comment, to include the ini text instead, and add
comments saying `; here marked default` `; here real default`
alex updated this revision to Diff 81720.
alex added a comment.
Anchor in regex, comment
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29326?vs=81664=81720
BRANCH
firefox_bookmarks_fix_extraction (branched from master)
REVISION DETAIL
alex added inline comments.
INLINE COMMENTS
> bruns wrote in firefox.cpp:185
> Can this ever be > 1?
For normal use not but if you have multiple versions of Firefox with multiple
profiles installed and want to launch a profile in a specific version.
REPOSITORY
R120 Plasma Workspace
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
The summary needs some text which works without any images
The code needs some comment which tells how the selection logic works and why
it is as it is.
INLINE COMMENTS
>
alex created this revision.
alex added reviewers: Plasma, ngraham, bruns, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
BUG 418526
The profile group with the value `Default=1` is not always the
