D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:2bf19bb7c59d: Add context for Automatic strings (authored by yurchor). REPOSITORY R116 Plasma Network Management

D29359: Add context for "Automatic" strings

2020-05-09 Thread Eloy Cuadra
ecuadra accepted this revision. ecuadra added a comment. Yes. Sorry for the delay. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29359 To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra Cc: ecuadra, plasma-devel, Orage,

D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
yurchor added a comment. @ecuadra Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29359 To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29359: Add context for "Automatic" strings

2020-05-03 Thread Yuri Chornoivan
yurchor updated this revision to Diff 81774. yurchor added a comment. Use "comment" instead of "context", fix extracomment according to https://tsdgeos.blogspot.com/2011/05/qt-designer-texts-disambiguation-vs.html REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST

D29359: Add context for "Automatic" strings

2020-05-02 Thread Eloy Cuadra
ecuadra requested changes to this revision. ecuadra added a comment. This revision now requires changes to proceed. I think the right attribute to adding context to .ui files is "comment" instead of "context". The attribute "context" is only for .rc and .kcfg files ;-) See

D29359: Add context for "Automatic" strings

2020-05-02 Thread Yuri Chornoivan
yurchor created this revision. yurchor added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. yurchor requested review of this revision. REVISION SUMMARY "Some of these topics are masculine gender and others are