D29395: Refactor MediaController

iasensio added a comment. Any chance to retake this and move it to invent? This is really useful for an extension of the media controller I'm mantaining, and will help to eventually upsream it (al least partially) I have a branch based on this MR with some fixes to it, and

D29395: Refactor MediaController

meven added a comment. ping @cblack and reviewers The commit message could mention the UI changes as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: meven, kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel,

D29395: Refactor MediaController

kmaterka added a comment. Any update on this? I really like the idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29395: Refactor MediaController

cblack updated this revision to Diff 83084. cblack added a comment. Guess that segfault wants to resolve itself :D REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29395?vs=83073=83084 BRANCH arcpatch-D29395_1 REVISION DETAIL

D29395: Refactor MediaController

cblack added inline comments. INLINE COMMENTS > broulik wrote in Media.qml:6 > Make this a `QtObject` Seems to cause a segfault with the data source. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: iasensio, broulik, trmdi,

D29395: Refactor MediaController

cblack updated this revision to Diff 83073. cblack marked 8 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29395?vs=81831=83073 BRANCH arcpatch-D29395 REVISION DETAIL

D29395: Refactor MediaController

cblack added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:99 > Unrelated cleanup a cleanup is unrelated in a cleanup patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: broulik, trmdi,

D29395: Refactor MediaController

broulik added a comment. Generally +1 Nice idea with this `Media` singleton INLINE COMMENTS > ExpandedRepresentation.qml:65 > +} > +Media.lockPositionUpdate= false > +} Coding style, space > ExpandedRepresentation.qml:99 > seekSlider.value

D29395: Refactor MediaController

trmdi added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138:

D29395: Refactor MediaController

cblack added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138:

D29395: Refactor MediaController

ngraham added a comment. Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138: Screenshot_20200503_202710.png REPOSITORY R120 Plasma

D29395: Refactor MediaController

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY MediaController is refactored to: 1. make the code easier to read and therefore more