ngraham closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29437
To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,
ngraham added a comment.
So is this good to go?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29437
To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen,
ngraham added a comment.
Oh, so then this patch is in fact an accidental Qt6 readiness patch? :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29437
To: ngraham, cblack, #plasma
Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
ahiemstra added a comment.
Actually I'm fairly sure `font: someFont` is still going to work, it's
`font.something: somethingElse` syntax that's going away, instead becoming
something like `font: Font { something: somethingElse }`.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
ngraham added a comment.
So you can't set `font:` in Qt6 or something? Would we have to do this?
font.pointSize: theme.smallestFont.pointSize
font.styleName: theme.smallestFont.styleName
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29437
To:
apol added a comment.
You can do that now but this behaviour is deprecated and disallowed in Qt 6
AFAIK.
I don't know a better way of doing this, so +0 from me.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29437
To: ngraham, cblack, #plasma
Cc:
ngraham created this revision.
ngraham added reviewers: cblack, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Otherwise we're discarding style information possibly set in
the user's small font
