D29476: WIP: Port klipper to use wayland clipboard

davidedmundson abandoned this revision. davidedmundson added a comment. Moving to invent REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n,

D29476: WIP: Port klipper to use wayland clipboard

davidedmundson updated this revision to Diff 82650. davidedmundson added a comment. shuffle files about REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29476?vs=82106=82650 BRANCH davidedmundson/clipboard2 REVISION DETAIL

D29476: WIP: Port klipper to use wayland clipboard

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in CMakeLists.txt:16 > I don't seem to have your home directory on my system :) Never mind :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc: ngraham, cblack,

D29476: WIP: Port klipper to use wayland clipboard

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:16 > +ecm_add_qtwayland_client_protocol(systemclipboard_SRCS > +PROTOCOL > /home/david/projects/kde5/src/kde/workspace/kwayland-server/src/protocols/wlr-data-control-unstable-v1.xml > +BASENAME wlr-data-control-unstable-v1

D29476: WIP: Port klipper to use wayland clipboard

cblack added inline comments. INLINE COMMENTS > systemclipboard.cpp:61 > + > +#include "qwayland-wlr-data-control-unstable-v1.h" > + Is there a reason this `#include` is all the way down here instead of at the top of the file? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29476: WIP: Port klipper to use wayland clipboard

davidedmundson updated this revision to Diff 82106. davidedmundson added a comment. Fix the klipper code to handle detecting null buffer better X code expected a valid QMimeData object with no contents REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29476: WIP: Port klipper to use wayland clipboard

apol added a comment. +1 INLINE COMMENTS > systemclipboard.cpp:63 > + > +class DataControlDeviceManager : public > QWaylandClientExtensionTemplate > +, public QtWayland::zwlr_data_control_manager_v1 Maybe split the DataControl classes into a separate file? > systemclipboard.h:45 >

D29476: WIP: Port klipper to use wayland clipboard

apol added a comment. In D29476#664751 , @nicolasfella wrote: > Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard? It's more that only few processes

D29476: WIP: Port klipper to use wayland clipboard

nicolasfella added a comment. Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc:

D29476: WIP: Port klipper to use wayland clipboard

zzag added a comment. +1 in general. > Not mergable as-is, especially the hardcoded line in CMakeLists but uploaded to show direction. Heh, it seems like we now have a good reason to upstream FindWaylandProtocols.cmake from KWayland to extra-cmake-modules. :-) REPOSITORY R120

D29476: WIP: Port klipper to use wayland clipboard

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Wayland has an entire new protocol for getting and setting clipboard when we