D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. Managed to re-introduce https://bugs.kde.org/show_bug.cgi?id=414045, so it looks like that's not related to this. Will fix it in another patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82324. ngraham added a comment. Move the config bar as the panel changes thickness REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82280=82324 BRANCH panel-adjustment-adjustment (branched from master)

D29535: Change panel thickness adjustment UI to use a SpinBox

abetts added a comment. +1 from me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham planned changes to this revision. ngraham added a comment. Need to re-implement the panel thickness change handling REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage,

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a subscriber: ahiemstra. ngraham added a comment. An idea brought up by @ahiemstra would be to add dragability into the SpinBox control itself, which was suggested in T9460 and would automatically re-implement/preserve draggability. I can

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. In D29535#666303 , @abetts wrote: > I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. I considered that, but

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82280. ngraham marked an inline comment as done. ngraham added a comment. Use less arbitrary min and max values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82277=82280 BRANCH

D29535: Change panel thickness adjustment UI to use a SpinBox

abetts added a comment. I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg,

D29535: Change panel thickness adjustment UI to use a SpinBox

cblack added inline comments. INLINE COMMENTS > ToolBar.qml:119-120 > + > +from: 2 > +to: 960 > +stepSize: 2 These values seem arbitrary. Could it be possible to base off the screen dimensions? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham created this revision. ngraham added reviewers: abetts, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We receive many complaints and bug reports about the current UI for adjusting panel