D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham abandoned this revision. ngraham added a comment. Oh I forgot that it was only in 5.19. We can continue in D29633 , it's better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29636 To: ngraham, broulik, #pla

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:61 > +} else { > +return i18n("Battery charging, currently at %1%", > pmSource.data.Battery.Percent) > } Also, just because it's plugged in, doesn't mean it's charging. REPOSITORY R12

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18. Also, D29633 REPOSITORY R120 Plasma Workspace RE

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

yurchor accepted this revision as: yurchor. yurchor added a comment. This revision is now accepted and ready to land. Thanks. No objections for porting this into a stable translation branch from the Ukrainian team. REPOSITORY R120 Plasma Workspace BRANCH fix-non-updating-battery-tooltip

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ltoscano added a comment. Adding a few more details to make it easier to decide on the localization side: - Plasma 5.18 is the new LTS - its next releases (5.18.6) is currently planned for September 17th, 2020. I'd say there is enough time to fix this translation, and having the co

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham created this revision. ngraham added reviewers: broulik, Plasma, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Current code only updates the text on the "not charging" condition, causing