D29637: Introduce ImageColors

2020-05-14 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:3986ad9d0955: Introduce ImageColors (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29637?vs=82645=82820#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D29637: Introduce ImageColors

2020-05-12 Thread Marco Martin
mart updated this revision to Diff 82645. mart marked 12 inline comments as done. mart added a comment. - adress feedbacks REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29637?vs=82537=82645 BRANCH mart/imageColors REVISION DETAIL

D29637: Introduce ImageColors

2020-05-11 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > colorutils.h:182 > +/** > + * Returns the Cielab "Chroma" of the color which is a slightly better > quantificator for how much a color appears > https://en.wikipedia.org/wiki/Colorfulness > + * This is how much a color looks diffenent

D29637: Introduce ImageColors

2020-05-11 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > imagecolorstest.qml:1 > + > +import QtQuick 2.12 There's no test cases here, this should probably go in examples. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29637 To: mart, #kirigami Cc: cblack, plasma-devel,

D29637: Introduce ImageColors

2020-05-11 Thread Marco Martin
mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY ImageColors is a class to extract color statistics out of an image. it supports as source : -