D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in UpdatesPage.qml:39 > "Update Issue" Oops, thanks. Fixed in 11cf0dc694f92551f75617b664cd3e7e49e98df8 . REPOSITORY

D29709: Give all OverlaySheets consistent headers

GB_2 added inline comments. INLINE COMMENTS > UpdatesPage.qml:39 > id: sheet > +header: Kirigami.Heading { text: i18n("Update issue") } > + "Update Issue" REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol,

D29709: Give all OverlaySheets consistent headers

leinir accepted this revision. leinir added a comment. Yay consistency! Good idea (and timely ;) ) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discover_software_store, #vdg, leinir Cc: leinir,

D29709: Give all OverlaySheets consistent headers

This revision was automatically updated to reflect the committed changes. Closed by commit R134:fb1880d436a8: Give all OverlaySheets consistent headers (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82735=82736

D29709: Give all OverlaySheets consistent headers

ngraham updated this revision to Diff 82735. ngraham marked an inline comment as done. ngraham added a comment. Remove testing thingy that snuck in REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82734=82735 BRANCH master

D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added a comment. String freeze is tomorrow. INLINE COMMENTS > apol wrote in ApplicationPage.qml:282 > I guess this was for testing? Yes, to work around ODRS flakiness. :( REPOSITORY R134 Discover Software Store REVISION DETAIL

D29709: Give all OverlaySheets consistent headers

apol added a comment. +1 for the change btw, thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29709: Give all OverlaySheets consistent headers

apol added a comment. We are in string freeze right now, aren't we? INLINE COMMENTS > ApplicationPage.qml:282 > enabled: appInfo.application.isInstalled > -visible: reviewsModel.backend && > reviewsModel.backend.isResourceSupported(appInfo.application) > +//

D29709: Give all OverlaySheets consistent headers

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY OverlaySheet has a `header:` property typically used to give the sheet