D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-23 Thread Matt Kovacs
kkoma added a comment. In D29798#672261 , @ngraham wrote: > You're probably right. This was a pretty lazy patch. > > The inherent challenge here is that desktop wallpapers are per-containment ("Containment" means a screen or activity), while

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-20 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. All right, I'll abandon this revision and turn it into a Phab task: T13180: Make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once REPOSITORY R120

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-20 Thread Niccolò Venerandi
niccolove added a comment. I agree with a single KCM called wallpapers used to set all wallpaper in System Settings. Not a fan of having so many apply buttons, but I'm sure we can come up with something good. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. In D29798#672886 , @mart wrote: > the length of that button text is quite daunting, i fear imagining how would be in geman :p Indeed, and Brazilian Portuguese, and probably many others too. What are your

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-19 Thread Marco Martin
mart added a comment. the length of that button text is quite daunting, i fear imagining how would be in geman :p REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29798 To: ngraham, #vdg, #plasma Cc: mart, niccolove, plasma-devel, Orage, LeGast00n,

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham added a comment. You're probably right. This was a pretty lazy patch. The inherent challenge here is that desktop wallpapers are per-containment ("Containment" means a screen or activity), while the lock and login screens are per-session. A further complication is that the login

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Niccolò Venerandi
niccolove added a comment. I'm a bit torn about this. It is indeed very nice, but at the same time I don't feel like it's the right solution. Ignoring minor complaints I'd have ("it's a very large button!") it doesn't feel right that the user, in order to change login wallpaper, would think

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This should make it a bit easier for people to change the wallpapers in all three places.