D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment. Ohhh, okay, thanks anyway REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Ah, it doesn't cherry-pick cleanly. You'll have to wait for 5.20, sorry. This is a good incentive to start living on git master. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Oh you mean both of them. Yeah, seems reasonable. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment. Right, but they can be cherry-picked the the **Plasma 5.19**. In truth, I'm tired of editing these files after every Plasma update☹️ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. In D29818#672947 , @epopov wrote: > In D29818#672942 , @ngraham wrote: > > > was landed on master, not 5.19 > > > Can it be moved to Plasma 5.19? Rut the

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov added a comment. In D29818#672942 , @ngraham wrote: > was landed on master, not 5.19 Can it be moved to Plasma 5.19? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Oops, sorry for not catching that. D29652 was landed on master, not 5.19, so it's not urgent. Thanks. Note that we have migrated to GitLab; would you mind submitting future patches as Merge

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Eugene Popov
epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY In D29652 , I made an annoying mistake: I removed the check if