D3754: expose toggleWidgetExplorer through dbus

davidedmundson closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 To: mvourlakos, #plasma, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mart added a comment. expanding of why it should be reverted Its only use case is for another process that wants to pretend it's part of the shell, which is not a supported use case neither should be, both for sake of maintainability and of course wayland. REPOSITORY R120 Plasma

[Differential] [Reopened] D3754: expose toggleWidgetExplorer through dbus

mart reopened this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

mart added a comment. I disagree, this commit should be reverted REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart Cc:

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added a comment. thank u ! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, davidedmundson, #plasma Cc: plasma-devel, lesliezhai,

[Differential] [Closed] D3754: expose toggleWidgetExplorer through dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:805d17664b30: expose toggleWidgetExplorer through dbus (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3754?vs=9205=9223

[Differential] [Accepted] D3754: expose toggleWidgetExplorer through dbus

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH toggle REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart,

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added a comment. In https://phabricator.kde.org/D3754#70294, @davidedmundson wrote: > Code is fine, but what's the intended use? Intended use is for all the apps that leave outside plasmashell and want to provide a unified experience with it... Such a case is the next

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

davidedmundson added a comment. Code is fine, but what's the intended use? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, mart, davidedmundson

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added reviewers: mart, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, mart, davidedmundson Cc: plasma-devel, lesliezhai,

[Differential] [Request, 4 lines] D3754: expose toggleWidgetExplorer through dbus

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY --shows/hides the WidgetExplorer through dbus Test Plani: trigger widget explorer from command