ltoscano added inline comments.
INLINE COMMENTS
> main.qml:55
> +checked: checkable
> +iconSource: appletEnabled ? i18n("application-menu") :
> i18n("emblem-warning")
> onClicked: {
A bit late to the party, but if this is the freedesktop name of an icon, then
it should
chinmoyr closed this revision.
chinmoyr added a comment.
Closed with commit
https://phabricator.kde.org/R120:fa06aac99b2fdec758a3854d3a9c61d8ef69ba59
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4070
EMAIL PREFERENCES
https://phabricator.kde.org/settin
broulik accepted this revision.
broulik added a reviewer: broulik.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4070
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: chinmoyr, davidedmundson, broulik
Cc: broulik, plasma-de
chinmoyr updated this revision to Diff 10053.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4070?vs=10051&id=10053
REVISION DETAIL
https://phabricator.kde.org/D4070
AFFECTED FILES
applets/appmenu/lib/CMakeLists.txt
applets/appmenu/lib/appmenua
broulik added a comment.
I just noticed when I change the setting in the KCM the icon changes to the
warning icon but the button stays enabled, only if I restart plasma the button
is disabled
INLINE COMMENTS
> appmenuapplet.h:69
> +bool appletEnabled() const;
> +void updateAppletEna
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4070
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: chinmoyr, davidedmundson
Cc: brouli
chinmoyr updated this revision to Diff 10051.
chinmoyr added a comment.
got rid of all useless config props
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4070?vs=10042&id=10051
REVISION DETAIL
https://phabricator.kde.org/D4070
AFFECTED FILES
chinmoyr updated this revision to Diff 10042.
chinmoyr added a comment.
addressed Kai's concerns
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4070?vs=9981&id=10042
REVISION DETAIL
https://phabricator.kde.org/D4070
AFFECTED FILES
applets/app
broulik added inline comments.
INLINE COMMENTS
> appmenuapplet.h:36
>
> +Q_PROPERTY(bool useApplet READ useApplet NOTIFY useAppletChanged)
> +
Maybe "applicationMenuAppletEnabled" or something like that?
> main.qml:76
> +
> +PlasmaCore.ToolTipArea {
> + visible: !useAp
broulik added inline comments.
INLINE COMMENTS
> appmenuapplet.cpp:44
> // TODO Wayland PlasmaShellSurface stuff
> +QDBusConnection::sessionBus().connect(QStringLiteral("com.kde.kappmenu"),
> + QStringLiteral("/KAppMenu"),
I was wondering if we c
broulik added a comment.
> When applet is placed in a vertical panel force use the compact view.
Why? We can show the buttons below each other if the user wants to
INLINE COMMENTS
> appmenuapplet.cpp:109
> +
> +void AppMenuApplet::setUseApplet()
> +{
I think update instead of set is bet
chinmoyr created this revision.
chinmoyr added a reviewer: davidedmundson.
chinmoyr set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
1> Use applet only if appli
12 matches
Mail list logo
