This revision was not accepted when it landed; it landed in state "Changes
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:832aa1b7d96f: [Baloo Widgets] Add KPropertiesDialog
Plugin with file metadata (authored by broulik).
REPOSITORY
ngraham accepted this revision as: VDG.
ngraham added a comment.
+1 from VDG, ship it!
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel,
broulik planned changes to this revision.
broulik added a comment.
I just saw I need to figure out the translation stuff but then it should be
good.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh,
broulik added a comment.
Nothing, I suppose. If noone objects I'll push this end of this week.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson,
ngraham added a comment.
Is anything blocking this?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel,
ZrenBot, progwolff, lesliezhai,
michaelh added a comment.
Sorry, we were overlapping. I should have hit the update page link in the
lower left.
BTW: Mind to explain this "Restricted Application added a project:" to
me? Please.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
broulik added inline comments.
INLINE COMMENTS
> michaelh wrote in baloofilepropertiesplugin.desktop:3
> That's was also my first thought. Not sure, but it might appear in dolphin
> settings > services
Btw you can submit multiple comments at once, this way I don't get a gazillion
emails each
michaelh added inline comments.
INLINE COMMENTS
> broulik wrote in baloofilepropertiesplugin.desktop:3
> I don't think this icon is visible in the UI anywhere, certainly not in the
> properties dialog
That's was also my first thought. Not sure, but it might appear in dolphin
settings >
broulik updated this revision to Diff 24934.
broulik added a comment.
- Show also for directories
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4614?vs=24928=24934
REVISION DETAIL
https://phabricator.kde.org/D4614
AFFECTED FILES
broulik added inline comments.
INLINE COMMENTS
> michaelh wrote in baloofilepropertiesplugin.desktop:3
> The baloo icon has a magnifying glass in it which is associated with
> searching.
> The tag-properties icon may be more appropriate.
I don't think this icon is visible in the UI anywhere,
michaelh added inline comments.
INLINE COMMENTS
> broulik wrote in baloofilepropertiesplugin.desktop:9
> The widget is primarily for showing additional file metadata (such as image
> sizes), there's no such extra information for folders, so I chose not to show
> it in this case.
I tag and
michaelh added inline comments.
INLINE COMMENTS
> baloofilepropertiesplugin.desktop:3
> +Type=Service
> +Icon=baloo
> +Name=File Meta Data Properties Page
The baloo icon has a magnifying glass in it which is associated with searching.
The tag-properties icon may be more appropriate.
REPOSITORY
broulik added inline comments.
INLINE COMMENTS
> michaelh wrote in baloofilepropertiesplugin.desktop:9
> MimeType=inode/directory;application/octet-stream ?
The widget is primarily for showing additional file metadata (such as image
sizes), there's no such extra information for folders, so I
michaelh added inline comments.
INLINE COMMENTS
> baloofilepropertiesplugin.desktop:9
> +X-KDE-ServiceTypes=KPropertiesDialog/Plugin
> +MimeType=application/octet-stream
MimeType=inode/directory;application/octet-stream ?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
broulik updated this revision to Diff 24928.
broulik added a comment.
- Rebase on master
- Just use `MimeType=application/octet-stream`
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4614?vs=11528=24928
REVISION DETAIL
broulik edited the test plan for this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel,
ZrenBot, progwolff, lesliezhai,
ngraham added a comment.
@broulik, any plans for this?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot,
progwolff, lesliezhai,
ngraham added a comment.
@broulik Any update here? Looks like this is about 99% done, and it would be
a shame not to to get it in. I often find myself wishing this information in
the Properties window.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To:
ngraham edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed,
broulik planned changes to this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg,
cfeck added a comment.
Kai, do you plan to work on the mentioned issues?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #vdg, #plasma, aacid, dfaure
Cc: cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> broulik wrote in baloofilepropertiesplugin.desktop:8
> I went through all extractors in KFileMetaData and looked at what they
> support.
>
> Unfortunately
broulik added a comment.
Ping
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
To: broulik, #plasma, #vdg, dfaure, aacid
Cc: fabianr, ltoscano, davidedmundson, plasma-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
broulik added a comment.
> Would it be possible to display the information together with the
information of the current first tab?
No.
Also, currently I cannot tell the thing to exclude certain information (like
file type and other info already shown on the first page).
REPOSITORY
ltoscano added a comment.
In https://phabricator.kde.org/D4614#88485, @fabianr wrote:
>
> A case could be made that this information is actually the most interesting
one, and could have a more prominent place, then on the last tab. Would it be
possible to display the
fabianr added a comment.
The layout looks good and is according to the HIG.
You probably shouldn't display duplicate information, but if I understood the
comments correct this is already addressed.
A case could be made that this information is actually the most interesting
one, and
broulik edited the test plan for this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D4614
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #vdg, dfaure, aacid
Cc: ltoscano, davidedmundson,
broulik updated this revision to Diff 11528.
broulik added a comment.
- Drop Message.sh change
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4614?vs=11350=11528
REVISION DETAIL
https://phabricator.kde.org/D4614
AFFECTED FILES
ltoscano added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Messages.sh:6
> is this not overwriting the generated extraction above?
As others pointed out: this is not needed: the new strings are already going to
be extracted into baloowidgets.pot. Try it for yourself:
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in baloofilepropertiesplugin.desktop:8
> where does this list come from?
I went through all extractors in KFileMetaData and looked at what they support.
Unfortunately KPropertiesDialog does not support wildcards. But then,
dfaure added inline comments.
INLINE COMMENTS
> Messages.sh:6
> +
> +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml
> | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot
> rm -f rc.cpp
This is obviously wrong, it would duplicate a lot of stuff that
davidedmundson added a comment.
looks sensible.
INLINE COMMENTS
> Messages.sh:6
> +
> +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml
> | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot
> rm -f rc.cpp
is this not overwriting the generated
broulik created this revision.
broulik added reviewers: Plasma, VDG, dfaure, aacid.
broulik set the repository for this revision to R824 Baloo Widgets.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This allows to view
33 matches
Mail list logo
