D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8028a500e3b2: Ignore NoDisplay=true .desktop entries when matching by Name. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4928?vs=12144=12145#toc REPOSITORY R120 Plasma

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein added a comment. In https://phabricator.kde.org/D4928#92423, @broulik wrote: > Shouldn't we *always* exclude them, not just for name matching? Two reasons: - I could imagine a case where someone wants to hide a .desktop from the menu (e.g. something like a KCM) but it

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, davidedmundson, broulik Cc: rempt, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein updated this revision to Diff 12144. hein added a comment. Remove debug. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4928?vs=12143=12144 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4928 AFFECTED FILES

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

broulik added a comment. Shouldn't we *always* exclude them, not just for name matching? INLINE COMMENTS > xwindowtasksmodel.cpp:646 > services = > KServiceTypeTrader::self()->query(QStringLiteral("Application"), > QStringLiteral("exist Exec and ('%1' =~

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein added a comment. And now the recent files work fine for Krita: F2676685: Screenshot_20170304_031400.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, broulik, davidedmundson Cc:

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

rempt added a comment. This seems correct to me :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, broulik, davidedmundson Cc: rempt, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY We currently match Krita by Name. It's classClass is "krita", but its DesktopEntryName is org.kde.krita.desktop. However, Krita also installs numerous additional .desktop entries to associate more