davidedmundson added a comment.
Fix in https://phabricator.kde.org/D5968
> Undefined means anything can happen
That is what the word means, but DBus isn't a black box. We do roughly know
what it will do.
If it was truly problematic, they would force the name to match, something
fvogt added a comment.
In https://phabricator.kde.org/D5012#111492, @davidedmundson wrote:
> Sure, but the current state of having two notification systems was already
undefined long before this patch.
Two notification systems? That's not the case here as far as I can tell.
davidedmundson added a comment.
Sure, but the current state of having two notification systems was already
undefined long before this patch.
Undefined trumps not being a defined state of not co-installable in this case.
There is a long term fix where service files will also go into
fvogt added a comment.
In https://phabricator.kde.org/D5012#111331, @davidedmundson wrote:
> There's no need for the .service file to match the dbus service name
>
> We change that, we get no file colision.
> I wrote a patch on Friday when someone told me on irc, but hadn't tested
davidedmundson added a comment.
There's no need for the .service file to match the dbus service name
We change that, we get no file colision.
I wrote a patch on Friday when someone told me on irc, but hadn't tested
because I had to rebuild something.
I'm back tomorrow, will upload
vpilo added a comment.
In https://phabricator.kde.org/D5012#110815, @lbeltrame wrote:
> Months later, it turns out that notify-osd ships a
org.freedesktop.Notifications.service already, so it conflicts with the one
made by this patch.
I wouldn't know what course of action would
lbeltrame added a comment.
Months later, it turns out that notify-osd ships a
org.freedesktop.Notifications.service already, so it conflicts with the one
made by this patch.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5012
To: vpilo,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bf889f7b94b: Add program to wait for D-Bus Notifications
services to register. (authored by vpilo).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5012?vs=12378=12609#toc
REPOSITORY
R120
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5012
To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson,
broulik, mck182
Cc: graesslin, dfaure,
vpilo added reviewers: graesslin, dfaure, davidedmundson, broulik, mck182.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5012
To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson,
broulik, mck182
Cc: graesslin, dfaure, davidedmundson,
vpilo added reviewers: Plasma, Plasma: Workspaces.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5012
To: vpilo, #plasma, #plasma_workspaces
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel,
progwolff, lesliezhai, ali-mohamed,
vpilo added a dependency: D4799: Delay notifications until desktop session has
loaded.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5012
To: vpilo
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel,
progwolff, lesliezhai, ali-mohamed,
vpilo created this revision.
vpilo added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Added program to wait for D-Bus Notifications services to register.
Needed for Plasma to delay showing notifications until the desktop has fully
loaded.
13 matches
Mail list logo