D5063: [sddm-theme] Improve positioning of Clock

2017-08-17 Thread David Edmundson
davidedmundson commandeered this revision. davidedmundson added a reviewer: graesslin. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: davidedmundson, #plasma, graesslin Cc: sebas, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D5063: [sddm-theme] Improve positioning of Clock

2017-08-17 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: davidedmundson, #plasma, graesslin Cc: sebas, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, lukas

D5063: [sddm-theme] Improve positioning of Clock

2017-05-05 Thread Sebastian Kügler
sebas added a comment. @graesslin Can you abandon this review? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: sebas, mart, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol,

D5063: [sddm-theme] Improve positioning of Clock

2017-04-21 Thread Marco Martin
mart added a comment. this has been implemented differently, can be dropped REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: mart, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5063: [sddm-theme] Improve positioning of Clock

2017-03-17 Thread Marco Martin
mart added a comment. ok, so, push https://phabricator.kde.org/D5061, then i can play on top of it :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5063: [sddm-theme] Improve positioning of Clock

2017-03-17 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5063#95576, @mart wrote: > if you are ok, i would give its layouting the same treatment of https://phabricator.kde.org/D4893 sure! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063

D5063: [sddm-theme] Improve positioning of Clock

2017-03-17 Thread Marco Martin
mart added a comment. something like https://paste.kde.org/pgelr0lc5 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5063: [sddm-theme] Improve positioning of Clock

2017-03-17 Thread Marco Martin
mart added a comment. if you are ok, i would give its layouting the same treatment of https://phabricator.kde.org/D4893 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5063: [sddm-theme] Improve positioning of Clock

2017-03-16 Thread Marco Martin
mart added a comment. I'm not sure i really like this approach, a columnlayout with an empty item just for spacing really looks like an hack. since it can't be reparented with the rest as it should stay fixed, i think the stack view (or more precisely, either MainBlock or

D5063: [sddm-theme] Improve positioning of Clock

2017-03-15 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is the same as https://phabricator.kde.org/R120:097db85e297aba8b4b3f0ddabcddf8a03b5482c0 for the lockscreen. The clock so far