This revision was automatically updated to reflect the committed changes.
Closed by commit R108:eaf41cb6c516: Animate quick tiling outline (authored by
broulik).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5262?vs=13729=13787
REVISION DETAIL
kvermette accepted this revision.
kvermette added a comment.
The movement clearly shows that the window will resize better than a strict
fade. +1!
On a side note, and this may be a separate revision to consider later, but we
may want to animate the transition as you move a window along
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5262
To: broulik, #vdg, #plasma, #kwin, graesslin
Cc: fabianr, graesslin, plasma-devel, kwin, spstarr, progwolff, lesliezhai,
ali-mohamed,
broulik updated this revision to Diff 13729.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Use moveResizeGeometry()
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5262?vs=13023=13729
REVISION DETAIL
fabianr added a comment.
+1, I like the new animation.
It adds information without introducing any new "clutter" or slow down
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5262
To: broulik, #vdg, #plasma, #kwin
Cc: fabianr, graesslin, plasma-devel, kwin, spstarr,
graesslin added inline comments.
INLINE COMMENTS
> geometry.cpp:3257
> if (maximizing)
> -outline()->show(electricBorderMaximizeGeometry(Cursor::pos(),
> desktop()));
> +outline()->show(electricBorderMaximizeGeometry(Cursor::pos(),
> desktop()), geometry());
> else
broulik edited the test plan for this revision.
broulik added a reviewer: VDG.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5262
To: broulik, #plasma, #kwin, #vdg
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When quick tiling animate the outline from the window geometry to the
position it would have afterwards.
This provides a visual hint to
