davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Marking as request changes to get it out my queue, as I think it needs more
discussion after my comment above
I could be maybe persuaded, but adding a bad
davidedmundson added a comment.
The thing this fixes is there.
It's arguably a tiny bit less relevant as people might now use a custom date
format in just the digital clock, instead of choosing a different locale for
times.
FWIW, I submitted a change that did exactly this at the
ngraham added a comment.
Is this still relevant?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5346
To: drosca, #plasma, mck182
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot,
drosca updated this revision to Diff 13394.
drosca added a comment.
Use correct form (not standalone) of day/month names
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5346?vs=13345=13394
BRANCH
master
REVISION DETAIL
drosca updated this revision to Diff 13345.
drosca added a comment.
Also fix language in compact representation when Long Date is configured
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5346?vs=13343=13345
BRANCH
master
REVISION DETAIL
drosca updated this revision to Diff 13343.
drosca added a comment.
Make uiLocale as property + fix language in tooltip
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5346?vs=13221=13343
BRANCH
master
REVISION DETAIL
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
Same as the other diff, if safe, good to go.
EDIT: I feel like we could wrap the `Qt.locale(Qt.locale().uiLanguages[0])`
into something shorter, maybe.
Possibly also keep it
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Same as https://phabricator.kde.org/D5345
TEST PLAN
I have English ui language + Czech time format. Months and days are now in
English and
