D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 21592. dvogel added a comment. Reworked for simplification. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=14856=21592 REVISION DETAIL https://phabricator.kde.org/D5381 AFFECTED FILES CMakeLists.txt

D5381: Add brightness control using ddcutil lib

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a3a61317ddeb: Add brightness control using ddcutil lib (authored by dvogel, committed by davidedmundson). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D5381: Add brightness control using ddcutil lib

davidedmundson accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D5381 To: dvogel, broulik, davidedmundson Cc: strobach, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 14854. dvogel added a comment. applied comments from d_ed fixed brightness jumping to previous position after brightness change: see DDCutilBrightness::brightness() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=14843=14854 REVISION

D5381: Add brightness control using ddcutil lib

davidedmundson added a comment. Looks good, I think I just have one comment about a leak, but the docs are confusing, so it's possible I'm wrong. INLINE COMMENTS > ddcutilbrightness.cpp:54 > + > +rc = ddca_create_dispno_display_identifier(iDisp+1, ); // > ddcutil uses 1 paded

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 14843. dvogel added a comment. Absence of ddcutil on the system is now handled: the ddcbrightness object is still instantiated in powerdevilupowerbackend, however, this is a dummy object, returning isSupported()=FALSE, making powerdevilupowerbackend

D5381: Add brightness control using ddcutil lib

dvogel added a comment. The final conclusion was that I should figure out some cmake to allow building without ddccontrol. I kind of did it locally (tho it's a bit dirty). The second big point is that powerdevil only supports one brightness controller at a time. The solution kbroulik

D5381: Add brightness control using ddcutil lib

davidedmundson added a comment. What's the current status of this? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5381 To: dvogel, broulik Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 13586. dvogel added a comment. Addition of a QTimer set by default to 1 sec to filter setBrightness calls: the actual DDC communication happens 1 sec after the last setBrightness() call. This solves brightness flickering when scrolling quickly on the

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 13395. dvogel marked 6 inline comments as done. dvogel added a comment. Applied changes suggested by reviewers. The only issue remaining is brightness restoration when waking up the monitor after shutting it down: we try to set brightness before the

D5381: Add brightness control using ddcutil lib

davidedmundson added inline comments. INLINE COMMENTS > ddcutilbrightness.cpp:149 > + > +ddca_get_vcp_value(m_displayHandleList.at(0), > + m_descrToVcp_perDisp.at(0)->value("Brightness"), you should check the return of this == 0 In case of error I would expect

D5381: Add brightness control using ddcutil lib

dvogel marked 9 inline comments as done. dvogel added a comment. Ok, so there is apparently an issue when the screen gets dimmed. Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation fault Using host libthread_db library "/usr/lib/libthread_db.so.1".

D5381: Add brightness control using ddcutil lib

broulik added a comment. Cool! INLINE COMMENTS > ddcutilbrightness.cpp:7 > +{ > +QList m_displayHandleList = > QList(); > +QList m_displayInfoList = QList(); No need to explicitly initialize these, the constructor could just remain empty > ddcutilbrightness.cpp:17 > + > +void

D5381: Add brightness control using ddcutil lib

dvogel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting up ddcutil for non-root CLI use is required first. Please refer to