This revision was automatically updated to reflect the committed changes.
Closed by commit R120:140c65f2236b: Expose PlasmaWindow::pid through
WaylandTasksModel. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5755?vs=14272=14465
hein added a dependent revision: D5818: Lift app identification heuristic out
of XWindowTasksModel and share it with WaylandTasksModel..
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5755
To: hein, #plasma, davidedmundson, sebas, graesslin
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Obviously commit embargo till 5.10 is branched is still in place.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5755
To: hein,
hein updated this revision to Diff 14272.
hein added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Document the limitations of the AppPid data role better.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
hein added a comment.
Argh, the lack of sleep ... I updated the wrong Phab. Give me a few mins ;)
INLINE COMMENTS
> graesslin wrote in waylandtasksmodel.cpp:340
> You are aware that pid is not always correct? Any process started by KWin
> shares KWin pid. Given that one need to be careful
hein updated this revision to Diff 14267.
hein added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Restricted Application added subscribers: KWin, kwin.
Put code working with the client connection into ShellClient.
Fix commit subject.
REPOSITORY
R108
graesslin added a comment.
Commit embargo till 5.10 is branched.
INLINE COMMENTS
> waylandtasksmodel.cpp:340
> } else if (role == AppPid) {
> -// FIXME Implement.
> +return window->pid();
> }
You are aware that pid is not always correct? Any process started by KWin
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D5747.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5755
AFFECTED FILES
