D5910: make shadows work on wayland

rikmills added a comment. > ! In https://phabricator.kde.org/D5910#114781, @hpereiradacosta wrote: > Working on fixing it. > Just a couple of ifdef missing. The fix you just pushed seems to have done the trick. Thank you. REPOSITORY R31 Breeze REVISION DETAIL

D5910: make shadows work on wayland

hpereiradacosta added a comment. In https://phabricator.kde.org/D5910#114772, @rikmills wrote: > This breaks builds on Neon and Kubuntu CI (Qt 5.7.1) > > http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console > > 05:10:59 In file included from

D5910: make shadows work on wayland

rikmills added a comment. This breaks builds on Neon and Kubuntu CI (Qt 5.7.1) http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59

D5910: make shadows work on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R31:d4940fe692c7: make shadows work on wayland (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=15156=15157 REVISION DETAIL

D5910: make shadows work on wayland

mart updated this revision to Diff 15156. mart added a comment. - use a const_iterator REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=14839=15156 BRANCH arcpatch-D5910 REVISION DETAIL https://phabricator.kde.org/D5910 AFFECTED FILES

D5910: make shadows work on wayland

mart edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5910 To: mart, #plasma, hpereiradacosta Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D5910: make shadows work on wayland

mart updated this revision to Diff 14839. mart added a comment. - use a different map to keep track of surfaces REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=14665=14839 BRANCH phab/waylandshadow REVISION DETAIL

D5910: make shadows work on wayland

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in breezeshadowhelper.cpp:177 > we use Expose everywhere else, why not here? It gets called a lot less it's a qwidget, doesn't get expose events > davidedmundson wrote in breezeshadowhelper.cpp:464 > this is currently leaking?

D5910: make shadows work on wayland

hpereiradacosta added inline comments. INLINE COMMENTS > breezeshadowhelper.cpp:177 > +QWidget* widget( static_cast( object ) ); > +if( event->type() == QEvent::Paint && ( > !_widgets.contains(widget) || _widgets.value(widget) == 0 ) ) > +{ Also,

D5910: make shadows work on wayland

anthonyfieroni added inline comments. INLINE COMMENTS > breezeshadowhelper.cpp:174 > { > +if( Helper::isWayland() ) > +{ We make check on every event for what we know what it is, does it better to use polymorphic helper? REPOSITORY R31 Breeze REVISION DETAIL

D5910: make shadows work on wayland

davidedmundson added a comment. We're going to be leaking both Surface and Shadow objects in installWaylandFilter, no? INLINE COMMENTS > breezeshadowhelper.cpp:177 > +QWidget* widget( static_cast( object ) ); > +if( event->type() == QEvent::Paint && ( >

D5910: make shadows work on wayland

mart added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5910 To: mart, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY since from Qt 5.8 QtWayland destroys its surfaces every time a window gets hidden and recreates them again when is shown (that's how the