This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ec31a507275c: Add a test that adds a notification and
closes it (authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6059?vs=15187&id=15188
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D6059_1
REVISION DETAIL
https://phabricator.kde.org/D6059
To: apol, #plasma, broulik, davidedmundson
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, p
apol updated this revision to Diff 15187.
apol added a comment.
Rebase to Plasma/5.10
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6059?vs=15186&id=15187
BRANCH
arcpatch-D6059_1
REVISION DETAIL
https://phabricator.kde.org/D6059
AFFECTED FI
apol updated this revision to Diff 15186.
apol added a comment.
Fix logic
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6059?vs=15069&id=15186
BRANCH
arcpatch-D6059_1
REVISION DETAIL
https://phabricator.kde.org/D6059
AFFECTED FILES
applet
apol added a comment.
Now it's just adding a test, it should be a straightforward review...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6059
To: apol, #plasma, broulik
Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed,
mck182 added a comment.
That's up to Kai/VDG, I guess. I was just wondering what changed
from the previous patch where everyone agreed to not do it because
it would be confusing.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6059
To: apol, #plasma, bro
apol retitled this revision from "Close notifications that don't have a default
action by clicking" to "Add a test that adds a notification and closes it".
apol removed a reviewer: VDG.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6059
To: apol, #plasma, bro
