D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. > I hope you don't mind that. On the contrary, I'm very glad it was picked up and even got to some mass media :) Sure, just ping me for review, I have a vacation in October. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#333791 , @Kanedias wrote: > @jgrulich In my regularly-irregular wanderings I noticed you already picked up changes from this diff and that's totally okay. Should I close this? I started looking into this

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich In my regularly-irregular wanderings I noticed you already picked up changes from this diff and that's totally okay. Should I close this? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#315732 , @Kanedias wrote: > @jgrulich you didn't change FindSPA, is it ok? I assume it is correct now, I got some fixes from Christophe Giboudeaux. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich you didn't change FindSPA, is it ok? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich thanks, I'll definitely use that. Have my hands fullatm but will definitely return to this diff and refresh once have some free time REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. There is now new release of PipeWire (version 0.2.0), which breaks API a bit. I would suggest to bump PipeWire requirements to 0.2.0 and change your code. There is also now a version file included so in future we can use this to check PW version during build time

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. One more possible thing to improve, I don't know if there is interest in supporting Gnome, but Gnome creates streams in BGRx format, which means it wouldn't mach your stream, if you want to support it you need to change it to something like : ":",

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich thanks a lot! I'll address these on weekend REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen,

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. I have two things I observed when implementing same in WebRTC to have this working in Firefox and Chrome: 1. Please use "Fru" for max_framerate and "Rru" for size, as it allows some negotiation when matching streams, I used the same in xdg-desktop-portal-kde

D6096: Add Wayland RemoteAccess capabilities to KRfb

zzag added inline comments. INLINE COMMENTS > pw_framebuffer.h:27 > +PWFrameBuffer(WId winid, QObject *parent = nullptr); > +virtual ~PWFrameBuffer() override; > + `virtual` is redundant. (also, it doesn't make sense to have both `virtual` and `override`) > pw_framebufferplugin.h:36 >

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @alexeymin This is a working version but I plan on adding stuff in the coming weekends. Just wanted to make sure there's someone motivated to review and merge this. Thanks for looking at my diffs. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. 1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed 2. Services should be started by DBus-activation, if that doesn't happen by whatever reason, first start `$ pipewire`, then `$ /usr/lib(exec)/xdg-desktop-portal`, it should in turn start

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. How exactly I can test if something works? And what are the requirements? PipeWire? Something else? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc:

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich @alexeymin please review new framebuffer approach This is the first draft of the implementation. I intend to add more features and fix review comments in the process. Missing features: - Only knows about first screen for now - Doesn't fail

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias updated this revision to Diff 34665. Kanedias edited the summary of this revision. Kanedias added a comment. Rewrite everything from scratch with Pipewire connectivity in mind REPOSITORY R437 Desktop Sharing CHANGES SINCE LAST UPDATE

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich , thanks for the pointers REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, lesliezhai, ali-mohamed,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Ah, that's because I use custom built XDP-KDE executable, installed to prefix instead of /usr REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: jgrulich, alexeymin, plasma-devel,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Nailed it, XDP just thinks KDE is inferior: XDP: loading /usr/share/xdg-desktop-portal/portals/kde.portal XDP: portal implementation for KDE XDP: portal implementation supports org.freedesktop.impl.portal.Access XDP: portal implementation supports

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#263873 , @Kanedias wrote: > Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try `auto reply = dbusXdpService->CreateSession(QVariantMap());` (with empty parameter map), the main

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#263885 , @Kanedias wrote: > Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch?

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To:

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try `auto reply = dbusXdpService->CreateSession(QVariantMap());` (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. The Screencast portal DBus interface is here: https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.ScreenCast.xml REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

jgrulich added a comment. In D6096#260229 , @Kanedias wrote: > @jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie. > Now I'm curious, you have `handle` and `session_handle` paths everywhere

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a subscriber: jgrulich. Kanedias added a comment. @jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie. Now I'm curious, you have `handle` and `session_handle` paths everywhere in Screencast interface inside XDP-KDE source.

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Too late did I realize that I'm making pipewire-based framebuffer, not xdp-kde based! I guess rewiring stuff will take another 3-4 days, sorry :D REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. I've digged through old diff and I must say, many of what's described here will be peeled off. For now we support read-only views, so I'll be focusing on it. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Sure, I'll be updating diff this week, will address concerns raised here REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot,

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. While I'm here and still remember some things that I don't like here - naming: There is a class `EventsPlugin` and files `eventsplugin.{h,cpp}`, class `EventsManager` and files `eventsmanager.{h,cpp}` and this is fine. But there is also class `EventHandler`,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @alexeymin , yeah, I've seen news about KRfb changes not so long ago. I'll fix this PR after support once remote access is upstreamed, it's quite troublesome to maintain so many changes around. Thanks for comments! P.S. The thing I'm stuck on is keyboard

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. There was a https://phabricator.kde.org/D5211, that added `xcb` framebuffer plugin; and after that `x11` framebuffer was removed from source tree ( https://phabricator.kde.org/R437:f131f7ddba584779144e7f737a98b24de430824c ), so this patch of needs to be slightly

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a dependency: D1231: Add Remote Access interface to KWayland. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias created this revision. Kanedias added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Patch for KRfb to work with RemoteAccess Wayland protocol. This does not yet work (I didn't test this), just rebased against latest KRfb