This revision was automatically updated to reflect the committed changes.
Closed by commit R119:586797610e08: [Panel Config] Scrolling over size button
increments size by 2 and shows… (authored by Zren).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
> Does this means I can merge to master now (and it'll appear in Plasma 5.13)?
Yes and yes.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6392
To: Zren, #plasma, davidedmundson
Cc: ngraham, mmustac, davidedmundson,
ngraham added a comment.
Yep, if you land this on master, it will wind up in 5.13.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6392
To: Zren, #plasma, davidedmundson
Cc: ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot,
progwolff,
Zren added a comment.
I do have commit access.
> Or it could go into master at anytime.
Does this means I can merge to master now (and it'll appear in Plasma 5.13)?
> only to save in some other unit
As so the plan is to serialize in dpi units? Eg: In units of `pixels /
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Not in 5.12.
I'm not a huge fan, as there's another open bug that the panel should follow
the Plasma style font-size based sizing. When we have both, presenting
ngraham added a comment.
Since there aren't any string changes, technically it could still go into the
5.12 branch. Or it could go into master at anytime.
I approve in concept, FWIW. But we should probably get formal approval from
@broulik or @davidedmundson first.
REPOSITORY
R119
Zren added a comment.
No one approved it so I never merged it in time for the Plasma 5.12 beta. So
I guess it'll have to wait for 5.12 to be released before I merge it into the
master branch?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6392
To: Zren,
ngraham added a comment.
FWIW, a major Linux reviewer mentioned this as a wishlist item in his recent
review of the Plasma 5.12 beta:
http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/
"If you wish to change the bottom panel height, you don’t have a field where
you can
mmustac added a comment.
Whats the status here? I would love to see this feature coming in the near
future.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6392
To: Zren, #plasma
Cc: mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff,
Zren marked an inline comment as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6392
To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Zren updated this revision to Diff 24808.
Zren retitled this revision from "[Panel Config] Scrolling over size button
increments size by 1 and shows current thickness" to "[Panel Config] Scrolling
over size button increments size by 2 and shows current thickness".
Zren edited the summary of this
11 matches
Mail list logo
