This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3257f5f92373: [CurrentContainmentActionsModel] Add
configurationChanged signal (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6443?v
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6443
To: broulik, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, ab
broulik added a comment.
Ping
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6443
To: broulik, #plasma
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
broulik updated this revision to Diff 16512.
broulik added a comment.
Connect signal to signal
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6443?vs=16511&id=16512
REVISION DETAIL
https://phabricator.kde.org/D6443
AFFECTED FILES
shell/curren
broulik updated this revision to Diff 16511.
broulik added a comment.
Use a separate connect
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6443?vs=16040&id=16511
REVISION DETAIL
https://phabricator.kde.org/D6443
AFFECTED FILES
shell/currentc
davidedmundson added a comment.
Can you please upload patches with arc otherwise we don't get to expand the
context.
Plugins have the lifespan of containment. (but could change as user toggles
things)
ConfigDlg lasts till it's quit
This model is owned by the ContainmentConfigView.
mart added inline comments.
INLINE COMMENTS
> broulik wrote in currentcontainmentactionsmodel.cpp:217
> Hmm I pass in "this" but it's nowhere guarded :/
yeah, it may crash.. whatever is in the 3rd param of the connect is the one you
can not worry about, the other one may get dangling..
the only
broulik added inline comments.
INLINE COMMENTS
> currentcontainmentactionsmodel.cpp:217
> QObject::connect(configDlg, &QDialog::accepted, pluginInstance,
> -[configDlg, pluginInstance] () {
> +[this, configDlg, pluginInstance] () {
> pluginInstance->c
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This allows the config UI to know when to enable the Apply button.
Currently we only do that when the shortcut or actions themselves change b
