This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7f9e7c854936: Terminology fixes in KCMs:
KDE-as-the-desktop -> Plasma (authored by ltoscano).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6469?vs=16149&id
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6469
To: ltoscano, davidedmundson
Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
ltoscano added a comment.
Ping?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6469
To: ltoscano
Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart
ltoscano updated this revision to Diff 16149.
ltoscano added a comment.
Remove a Plasma reference (generic session)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6469?vs=16097&id=16149
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
sebas added a comment.
Needs to smallish changes, then good to go in.
INLINE COMMENTS
> ltoscano wrote in emailclientconfig_ui.ui:12
> Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go
> away :)
Yeah, exactly. The KDE should go away here.
> lukas wrote in globalpath
ltoscano added inline comments.
INLINE COMMENTS
> lukas wrote in emailclientconfig_ui.ui:12
> I'd keep the old one as well, just for a better discoverability
Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away
:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
ht
lukas added inline comments.
INLINE COMMENTS
> ltoscano wrote in autostart.cpp:75
> Should this be "Session" or "Plasma Session"? Aren't the settings changed
> here valid for all desktops which follow the XDG spec?
Yes, it should be valid for all DEs (I'd vote for "Session" only then)
> emailc
ltoscano added a comment.
... and few in-line questions for the reviewers.
INLINE COMMENTS
> autostart.cpp:75
> KAboutData* about = new KAboutData(QStringLiteral("Autostart"),
> - i18n("KDE Autostart Manager"),
> +
ltoscano created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fix the reference to KDE (or remove them when not strictly needed).
TEST PLAN
The code still compiles.
REPOSITORY
R119 Plasma Desktop
B
