D6631: Fix compilation with strict libc (such as musl)

2017-07-21 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D6631#126937, @bcooksley wrote: > Sorry, looks like it's still unhappy (another different error). This time it's complaining about gettimeofday() > According to https://github.com/kinetiknz/cubeb/issues/6 defining XOPEN_SOURCE

D6631: Fix compilation with strict libc (such as musl)

2017-07-20 Thread Ben Cooksley
bcooksley added a comment. Sorry, looks like it's still unhappy (another different error). This time it's complaining about gettimeofday() According to https://github.com/kinetiknz/cubeb/issues/6 defining XOPEN_SOURCE will sort this, but i'm not sure if musl is okay with that? REPOSITORY

D6631: Fix compilation with strict libc (such as musl)

2017-07-19 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D6631#126366, @bcooksley wrote: > Thanks for the quick fix. > > Getting closer - got a different error this time... > https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/ This fix wasn't as quick, I

D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Ben Cooksley
bcooksley added a comment. Thanks for the quick fix. Getting closer - got a different error this time... https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/ REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma, mart

D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D6631#126101, @bcooksley wrote: > Clang doesn't seem to like this: https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/4/console Thanks. Looks from the build log like it's not good enough to define the

D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Ben Cooksley
bcooksley added a comment. Clang doesn't seem to like this: https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/4/console REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma, mart Cc: bcooksley, plasma-devel, ZrenBot,

D6631: Fix compilation with strict libc (such as musl)

2017-07-12 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R106:257591cf462d: Fix compilation with strict libc (such as musl). (authored by mpyne). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6631?vs=16520=16590 REVISION

D6631: Fix compilation with strict libc (such as musl)

2017-07-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6631: Fix compilation with strict libc (such as musl)

2017-07-11 Thread Michael Pyne
mpyne edited the summary of this revision. mpyne removed a reviewer: Frameworks. mpyne changed the repository for this revision from R111 KSysguard Library to R106 KSysguard. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma Cc: plasma-devel,

D6631: Fix compilation with strict libc (such as musl)

2017-07-11 Thread Michael Pyne
mpyne created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many of the functions we use implicitly are not part of the C standard library so we have to specific that we're pulling from POSIX, X/Open,