D6697: Allow to change toolbar font separately again

This revision was automatically updated to reflect the committed changes. Closed by commit R135:86be8d49d898: Allow to change toolbar font separately again (authored by rkflx). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D66

D6697: Allow to change toolbar font separately again

fvogt accepted this revision. fvogt added a comment. Latest changes look good to me as well. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma, davidedmundson, fvogt Cc: fvogt, davidedmundson, j

D6697: Allow to change toolbar font separately again

rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma, davidedmundson Cc: fvogt, davidedmundson, jensreuterberg,

D6697: Allow to change toolbar font separately again

rkflx updated this revision to Diff 18431. rkflx marked 2 inline comments as done. rkflx added a comment. - add FIXED-IN - rebase on Fabian's changes - take care of Fabian's comments (extend upd, remove pl) REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPD

D6697: Allow to change toolbar font separately again

rkflx marked 2 inline comments as done. rkflx added inline comments. INLINE COMMENTS > fvogt wrote in fonts_global_toolbar.pl:12 > Not sure, but maybe the script should only read/change the `[General]` > section? Not done in the other update scripts either and not strictly necessary, but you a

D6697: Allow to change toolbar font separately again

fvogt added a comment. Looks good to me as well (+ the other patch), I just added two comments. INLINE COMMENTS > fonts_global_toolbar.pl:12 > +{ > +chomp; > +$generalFont = $1 if ($_ =~ /font=(.*)/); Not sure, but maybe the script should only read/change the `[General]` section? >

D6697: Allow to change toolbar font separately again

rkflx requested review of this revision. rkflx added a subscriber: fvogt. rkflx added a comment. This revision is now accepted and ready to land. No worries and thanks for the review :) I'll setup my recently granted commit access and commit to master (even though originally intended for

D6697: Allow to change toolbar font separately again

davidedmundson accepted this revision. davidedmundson added a comment. Hey, sorry about the lack of review. I think the default being the current default makes the most sense. Patch absolutely makes sense. I like how you even added an update script. Lets merge this as-is, and then d

D6697: Allow to change toolbar font separately again

rkflx planned changes to this revision. rkflx added a comment. No review in over a month. On the positive side, I got more ideas in the meantime. Let's see if I can find another way to change the toolbar font without affecting single QToolButtons. Things to try (maybe even both, dependin

D6697: Allow to change toolbar font separately again

rkflx added a subscriber: jensreuterberg. rkflx added a comment. Screenshots for Plasma 5 with toolbar font sizes 8pt, 9pt (former broken default), 10pt (new default, same as menu bar): | F3810800: plasma5-08pt.png | F3810802: plasma5-09pt.png

D6697: Allow to change toolbar font separately again

rkflx added a comment. Some screenshots of applications with QToolButtons and other elements looking out of place with a tiny toolbar font size: | F3810790: kdevelop+kate.png | | Toolviews in KDevelop (bad

D6697: Allow to change toolbar font separately again

rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D6697: Allow to change toolbar font separately again

rkflx added a dependent revision: D6698: Keep default toolbar font in fonts KCM in sync with plasma-integration. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, a

D6697: Allow to change toolbar font separately again

rkflx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fonts KCM supports changing the toolbar font, but with the port to QPA/Plasma 5 in https://phabricator.kde.org/R446:aa16577f402549c7372116