This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bf0e0f071ceb: [aurorae] Add support for shaded windows
(authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6719?vs=16774&id=16825
REVISION DETAIL
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
aurorae-support-shaded
REVISION DETAIL
https://phabricator.kde.org/D6719
To: graesslin, #kwin, #plasma, cfeck
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-moham
graesslin added inline comments.
INLINE COMMENTS
> cfeck wrote in aurorae.cpp:407
> Do you remember why the other connection needed to be queued?
Yes, when maximizing it can happen that the deco gets destroyed. It would act
like a delete this without the queued connection. With shade this canno
cfeck added inline comments.
INLINE COMMENTS
> aurorae.cpp:407
> connect(client().data(),
> &KDecoration2::DecoratedClient::maximizedChanged, this,
> &Decoration::updateBorders, Qt::QueuedConnection);
> +connect(client().data(), &KDecoration2::DecoratedClient::shadedChanged,
> this, &
graesslin updated this revision to Diff 16774.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
New approach to the problem
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6719?vs=16748&id=16774
BRANCH
aurorae-su
graesslin planned changes to this revision.
graesslin added a comment.
Unfortunately there are still themes which cause glitches.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6719
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, a
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Aurorae did not render correctly. This change addresses the problem for
both maximized and restored windows.
BUG: 373319
FIXED-IN
