D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 23710. januz added a comment. Reducing the scope of this patch a bit, it now sets the clock fontsize to a fixed value. This prevents all the layout issues from relative scales. The code changes now are minimal, so it won't add pile more complexity on the

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. In https://phabricator.kde.org/D6764#172831, @mmustac wrote: > I think this describes the main problem for most users (including me) very good: > KDE Forum: Padding in plasma panels Actually I posted

D6764: Add font size setting to the digital clock plasmoid

ngraham added a comment. Exactly: the default size is too big. I think if we just make the default size smaller, the complaints will go away. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, mart,

D6764: Add font size setting to the digital clock plasmoid

mmustac added a comment. I think thisdescribes the main problem for most users (including me) very good: KDE Forum: Padding in plasma panels It look out of place when and jumps right into the eyes. I have three screens, the main screen

D6764: Add font size setting to the digital clock plasmoid

ngraham added a comment. It also might be worth stepping back and asking why people want a size adjustment setting in the first place. I'm willing to bet that most of the time, it's because they think the default size is too big (because it is really big--way bigger than any of the other

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. Thanks for the replies guys. @davidedmundson Good point! I'll keep a close eye on the current code while I work on this. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel,

D6764: Add font size setting to the digital clock plasmoid

davidedmundson added a comment. If its good, sure. If its simpler because it doesn't do all the things, then no. It's important to know why some things are done the way they were. Otherwise we just go round in circles fixing the reintroducing bugs. Like there's the implicit size

D6764: Add font size setting to the digital clock plasmoid

ngraham added a comment. Given how often this codebase's unmaintainability comes up, I think that would be very welcome! REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff,

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. So, I've been fighting with this for a few weekends already and I just can't get it to work reliably with a relative scale. The spacing goes all wonk and sometimes the labels' font size don't change the way you expect them to (probably because of the maze of

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. > I think this explains why you haven't had a review, this existing code is already sketchy as-is :/ > But we should be trying to fix that not just all of us ignoring it. Sorry about that. No problem, I can understand the dread of piling stuff on code that

D6764: Add font size setting to the digital clock plasmoid

davidedmundson added a comment. > i don't think i like the idea of adding yet another setting on this already rather fragile code I think this explains why you haven't had a review, this existing code is already sketchy as-is :/ But we should be trying to fix that not just all of us

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. //PING// Hey guys, the beta is starting next week. Any chance we can still land this or https://phabricator.kde.org/D6813 for 5.11? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot,

D6764: Add font size setting to the digital clock plasmoid

ngraham added a comment. Any reasons not to land this or https://phabricator.kde.org/D6813? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. @Zren Thanks! I've updated the rev @mart I can see some parts of the code look a little too hacky but the new setting is nothing fancy, and I've been using for about 3 weeks without issues. It also fixes these two bugs: https://bugs.kde.org/show_bug.cgi?id=191889 and

D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 17044. januz added a comment. - Use pixelSize with units.devicePixelRatio to set the size - Update the default value to fit with the default panel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=17043=17044 REVISION DETAIL

D6764: Add font size setting to the digital clock plasmoid

januz updated this revision to Diff 17043. januz added a comment. - Use pixelSize with units.devicePixelRatio - Update the default value CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=16852=17043 REVISION DETAIL https://phabricator.kde.org/D6764 AFFECTED FILES

D6764: Add font size setting to the digital clock plasmoid

Zren added inline comments. INLINE COMMENTS > DigitalClock.qml:473 > italic: plasmoid.configuration.italicText > -pixelSize: 1024 > +pointSize: plasmoid.configuration.fontSize > } We use `font.pixelSize` to avoid the

D6764: Add font size setting to the digital clock plasmoid

mart added a comment. i don't think i like the idea of adding yet another setting on this already rather fragile code REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6764: Add font size setting to the digital clock plasmoid

januz edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6764: Add font size setting to the digital clock plasmoid

januz created this revision. januz added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds a new setting to the digital clock plasmoid to change the font size for horizontal panels and desktop. It also sets a default (14) with a new