This revision was automatically updated to reflect the committed changes.
Closed by commit R119:76af2694e937: [Folder View Config] Make model writable
and drop custom setRowChecked method (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
mart added a comment.
+1
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
broulik updated this revision to Diff 17242.
broulik added a comment.
Emit checkedTypesChanged only when changed, I hoped model would be smart
enough not to change if the value was the same but implicit assignment always
ends up in setData
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
By implementing `setData` we make the `model` magic property writable and can
directly assign `model.checked` a new value.
Not only is this
